-
Notifications
You must be signed in to change notification settings - Fork 5
feat: HasX attributes #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jorenham @NeilGirdhar @lucascolley this doesn't resolve the current discussion re a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the Has*
protocols. Optype will cover the CanArray*
ones I think. There might be some that can't be expressed because Self
can't be passed as generic type argument, but I suppose we can deal with it when needed.
One nit is that ...
are not needed when there's a docstring, which already counts as an expression or statement or something.
What do we do about docstrings?
Yes, my pylint is complaining. But IMO empty methods should have |
Hmm good question. Maybe a numpy-esque |
Yea I guess there's something to be said for that. It just looks a bit weird to me to see a |
Signed-off-by: Nathaniel Starkman <[email protected]>
📌 pin the correct python version ⬆️ update optype version Co-authored-by: Nathaniel Starkman <[email protected]>
Signed-off-by: Nathaniel Starkman <[email protected]>
dfdc9fa
to
8096aff
Compare
Signed-off-by: Nathaniel Starkman <[email protected]> Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: Nathaniel Starkman <[email protected]> Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: Nathaniel Starkman <[email protected]>
8096aff
to
3793c1f
Compare
Requires #32. I'll rebase when that's in.